Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to specify how to decode unrecognized CBOR tag to any #475

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Add option to specify how to decode unrecognized CBOR tag to any #475

merged 1 commit into from
Feb 4, 2024

Conversation

ssuriyan7
Copy link
Contributor

@ssuriyan7 ssuriyan7 commented Jan 25, 2024 •
edited
Loading

Description

Adds a decoding option to specify the preferred return type when unmarshalling a data with an unknown tag.
If this option is not set, Unmarshal returns a value of type Tag{}. This ensures backward compatibility.
If the option is set, Unmarshal returns the unmarshalled content.

PR Was Proposed and Welcomed in Currently Open Issue

Checklist (for code PR only, ignore for docs PR)

  • Include unit tests that cover the new code
  • Pass all unit tests
  • Pass all 18 ci linters (golint, gosec, staticcheck, etc.)
  • Sign each commit with your real name and email.
    Last line of each commit message should be in this format:
    Signed-off-by: Firstname Lastname [email protected]
  • Certify the Developer's Certificate of Origin 1.1
    (see next section).

Certify the Developer's Certificate of Origin 1.1

  • By marking this item as completed, I certify
    the Developer Certificate of Origin 1.1.
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
660 York Street, Suite 102,
San Francisco, CA 94110 USA

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

fxamacker
fxamacker reviewed Jan 28, 2024
View reviewed changes
Copy link
Owner

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍 I left some comments about renaming and adding tests.

decode.go Outdated Show resolved Hide resolved
decode.go Outdated Show resolved Hide resolved
decode.go Outdated Show resolved Hide resolved
decode_test.go Outdated Show resolved Hide resolved
@fxamacker fxamacker changed the title Add decoding option for return type of data with an unknown tag Add option to specify how to decode unrecognized CBOR tag to any Jan 28, 2024
@ssuriyan7
Add decoding option for return type of data with an unknown tag
2c841f6 
Adds a decoding option to specify the preferred return type when unmarshalling a data with an unknown tag.
If this option is not set, Unmarshal returns a value of type Tag{}. This ensures backward compatibility.
If the option is set, Unmarshal returns the unmarshalled content.

Signed-off-by: Suriyan Subbarayan [email protected]
@ssuriyan7
Copy link
Contributor Author

@fxamacker , Thanks a lot for reviewing! I've incorporated all your suggestions. Please review.

fxamacker
fxamacker approved these changes Feb 4, 2024
View reviewed changes
Copy link
Owner

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks @ssuriyan7 for adding this decoding option and updating this PR!

@fxamacker fxamacker merged commit dd2eb91 into fxamacker:master Feb 4, 2024
17 checks passed
@fxamacker fxamacker mentioned this pull request Feb 4, 2024
Closed
@ssuriyan7 ssuriyan7 deleted the return-tag-content-option branch March 5, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxamacker fxamacker fxamacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssuriyan7 @fxamacker